Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#519] Fix: Test run failed for not finding host application for staging scheme #544

Merged
merged 2 commits into from
Dec 4, 2023
Merged

[#519] Fix: Test run failed for not finding host application for staging scheme #544

merged 2 commits into from
Dec 4, 2023

Conversation

Shayokh144
Copy link
Contributor

What happened 👀

  • Add new variable APP_DISPLAY_NAME as CFBundleName
  • Make PRODUCT_NAME = $(TARGET_NAME)

Insight 📝

  • APP_DISPLAY_NAME is used for showing different app name for different scheme
  • PRODUCT_NAME = $(TARGET_NAME) will fix bug not finding host application

Proof Of Work 📹

  • App name

pow1

  • All tests passed for both schemes

pow2

@Shayokh144 Shayokh144 added this to the 4.10.0 milestone Nov 17, 2023
@Shayokh144 Shayokh144 self-assigned this Nov 17, 2023
@Shayokh144 Shayokh144 linked an issue Nov 17, 2023 that may be closed by this pull request
Fix: Test run failed for not finding host application for staging scheme #519
Open
@blyscuit
Copy link
Collaborator

PRODUCT_NAME = $(TARGET_NAME) will fix bug not finding host application

This PR will resolve issue with host application because we will use APP_DISPLAY_NAME instead and PRODUCT_NAME now be the same for all scheme. Do I understand this correct? Or is the not finding host application still occur?

@Shayokh144
Copy link
Contributor Author

PRODUCT_NAME = $(TARGET_NAME) will fix bug not finding host application

This PR will resolve issue with host application because we will use APP_DISPLAY_NAME instead and PRODUCT_NAME now be the same for all scheme. Do I understand this correct? Or is the not finding host application still occur?

@blyscuit You are correct

@blyscuit blyscuit added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit a268748 Dec 4, 2023
2 checks passed
@blyscuit blyscuit deleted the fix/519-update-display-name branch December 4, 2023 10:04
@blyscuit blyscuit mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thieurom Thieurom Thieurom approved these changes

@markgravity markgravity markgravity approved these changes

@blyscuit blyscuit blyscuit approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@ducbm051291 ducbm051291 Awaiting requested review from ducbm051291 ducbm051291 is a code owner

@nkhanh44 nkhanh44 Awaiting requested review from nkhanh44 nkhanh44 is a code owner

Assignees

@Shayokh144 Shayokh144

Labels
type : bug
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

Fix: Test run failed for not finding host application for staging scheme
4 participants
@Shayokh144 @blyscuit @markgravity @Thieurom